[CCing the regression list, as it should be in the loop for regressions: https://docs.kernel.org/admin-guide/reporting-regressions.html] On 17.05.24 08:27, Frank Wunderlich wrote: > Am 17. Mai 2024 04:17:47 MESZ schrieb "Arınç ÜNAL" <arinc.unal@xxxxxxxxxx>: >> On 16/05/2024 23:48, Frank Wunderlich wrote: >>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >>> >>> After commit 868ff5f4944a >>> ("net: dsa: mt7530-mdio: read PHY address of switch from device tree") >>> the mt7531 switch on Bananapi-R64 was not detected. >>> >>> mt7530-mdio mdio-bus:00: reset timeout >>> mt7530-mdio mdio-bus:00: probe with driver mt7530-mdio failed with error -110 >>> >>> Fix this by adding phy address in devicetree. >>> >>> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >> >> I don't like the mention of the Linux kernel driver on the patch log. What >> you're fixing is the incorrect description of the switch's PHY address on >> the DTS file. Whether or not any driver from any project is actually >> reading it from the DTS file is irrelevant to this patch. That said, I >> already have a patch series I've been meaning to send the next version of >> that already addresses this. Please wait for that. Did you sent this? Because from what I see with my limited experience in this subsystem... > From my PoV it is a regression in next/6.10 ...I have to agree with Frank here. So it would be good to get this fixed before -rc1 is out to prevent more people from running into this. > because the driver change was merged (without "broadcast" fallback) and the dts patch [1] is not. > > I agree that my patch can be dropped because there was already one. > > regards Frank > > [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20240314-for-mediatek-mt7531-phy-address-v1-1-52f58db01acd@xxxxxxxxxx/ Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.