On Tue, May 28, 2024 at 02:28:08PM +0200, Konrad Dybcio wrote:
>
>
> On 5/27/24 10:07, Abel Vesa wrote:
> > Add the pmic-glink node and describe all 3 USB Type-C connectors. Do this
> > for USB only, for now. The DP port will come at a later stage since it
> > uses a retimer.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 143 ++++++++++++++++++++++++++++++
> > 1 file changed, 143 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> > index c5c2895b37c7..2fcc994cbb89 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> > @@ -49,6 +49,101 @@ chosen {
> > stdout-path = "serial0:115200n8";
> > };
> > + pmic-glink {
> > + compatible = "qcom,x1e80100-pmic-glink",
> > + "qcom,sm8550-pmic-glink",
> > + "qcom,pmic-glink";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
> > + <&tlmm 123 GPIO_ACTIVE_HIGH>,
> > + <&tlmm 125 GPIO_ACTIVE_HIGH>;
> > +
> > + connector@0 {
>
> Could you describe them somehow? e.g.
Which reminds me that we should add OF bindings for physical_location
driver.
>
>
> /* Left rear port */
> connector @0 {
>
>
> There is probably some better terminology to describe the one closer and
> farther away from the user, do as you will..
>
> For the QCP, they're numbered on the chassis
>
> Konrad
--
With best wishes
Dmitry
