On Thu, May 16, 2024 at 11:40:28PM +0300, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx> > > Add schema for imx8ulp's SIM reset controller. > > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx> > --- > .../bindings/reset/nxp,imx8ulp-sim-reset.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml > new file mode 100644 > index 000000000000..ec9a5c73e83c > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/nxp,imx8ulp-sim-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8ULP System Integration Module Reset Controller > + > +maintainers: > + - Liu Ying <victor.liu@xxxxxxx> > + > +description: | > + Some instances of i.MX8ULP's SIM may offer control over the > + reset of some components of a certain domain (e.g: AVD-SIM). > + As far as the DT is concerned, this means that the reset > + controller needs to be a child of the SIM node. > + > +properties: > + compatible: > + const: nxp,imx8ulp-avd-sim-reset > + > + '#reset-cells': > + const: 1 > + > +required: > + - compatible > + - '#reset-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/imx8ulp-clock.h> > + syscon@2da50000 { > + compatible = "nxp,imx8ulp-avd-sim", "syscon"; > + reg = <0x2da50000 0x38>; > + clocks = <&pcc5 IMX8ULP_CLK_AVD_SIM>; > + > + reset-controller { > + compatible = "nxp,imx8ulp-avd-sim-reset"; > + #reset-cells = <1>; > + }; > + }; Why do you need a child node here? No DT resources or anything for this 'sub-block'. Just put "#reset-cells" in the parent node. (Note that examples for MFDs like this go in the MFD binding rather than having incomplete examples here.) Rob