Hi,
On 4/25/24 18:30, Rob Herring wrote:
On Thu, Apr 25, 2024 at 09:48:31AM +0200, Patrick Delaunay wrote:
This patchset removes the unexpected comma in the PWR compatible
"st,stm32mp1,pwr-reg" and uses a new compatible "st,stm32mp1-pwr-reg"
in STM3MP15 device trees.
Why? I don't see any warnings from this. Yes, we wouldn't new cases
following this pattern, but I don't think it is worth maintaining
support for both strings. We're stuck with it. And the only way to
maintain forward compatibility is:
Yes, no warning because the compatible string are not yet checked by tools.
I propose this patch to avoid the usage of this compatible for other SoC
in STM32MP1 family.
I see the invalid compatible string when I reviewed the U-Boot patch to
add the PWR node for STM32MP13 family:
https://patchwork.ozlabs.org/project/uboot/patch/20240319024534.103299-1-marex@xxxxxxx/
So I prefer change the PWR binding before to have the same patch applied
on Linux device tree
compatible = "st,stm32mp1-pwr-reg", "st,stm32mp1,pwr-reg";
Yes, I will update the SoC patch with you proposal.
it is the only way to have compatibility of OLD Linux kernel (with old
driver) with NEW device tree.
I miss this compatibility issue.
Rob
Regards
Patrick
