Hello Steffen,
On 22.04.24 10:46, Steffen Trumtrar wrote:
> + dwmac->enet_clk_regmap = syscon_regmap_lookup_by_phandle(np, "enet_clk_sel");
> + if (IS_ERR(dwmac->enet_clk_regmap))
> + return PTR_ERR(dwmac->enet_clk_regmap);
> +
> + err = of_property_read_u32_index(np, "enet_clk_sel", 1, &dwmac->enet_clk_reg_off);
> + if (err) {
> + dev_err(dev, "Can't get enet clk sel reg offset (%d)\n", err);
> + return err;
> + }
This looks like the property is not optional. The property needs to stay optional
as not to break backwards compatibility with older device trees.
Cheers,
Ahmad
> }
>
> return err;
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
