On Thu, Apr 18, 2024 at 1:37 PM Frank Li <Frank.Li@xxxxxxx> wrote: > + lsm303arg@19 { > + compatible = "st,lsm303agr-accel"; > + reg = <0x19>; > + }; > + > + fxas21002c@20 { > + compatible = "nxp,fxas21002c"; > + reg = <0x20>; > + }; > + > + isl29023@44 { > + compatible = "isil,isl29023"; > + reg = <0x44>; > + interrupt-parent = <&lsio_gpio4>; > + interrupts = <11 2>; > + }; > + > + mpl3115@60 { > + compatible = "fsl,mpl3115"; > + reg = <0x60>; > + }; > + > + max7322: gpio@68 { > + compatible = "maxim,max7322"; > + reg = <0x68>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + l3g4250@69 { > + compatible = "st,l3g4200d-gyro"; > + reg = <0x69>; > + }; Same comment I did yesterday on another patch from you: none of these node names are generic.