On Thu, 04 Apr 2024 20:44:02 +1300 "Ryan Walklin" <ryan@xxxxxxxxxxxxx> wrote: Hi Viresh, Ryan, > On Thu, 4 Apr 2024, at 7:40 PM, Viresh Kumar wrote: > > Is it okay to merge all the changes via the cpufreq tree ? > > I have tested this series with an H700-based board, and have at least one speed-bin (1.032GHz) is not supported although the governor attempts to enable it based on the opp-supported-hw bitmask, and I am unable to reach the 1.5GHz bin at 1.16v (or higher) despite it working on the vendor BSP (kernel panic at boot if enabled), so this may need some slight rework. > > I have reached out to Andre on IRC to debug. So those test results look odd, especially since it seems to work on the BSP. I don't want to jeopardise this series over the oddity on this variant, so I am dropping the H700 specific speed bin for now. Not directly matching any known SoC variant now, it will fall back to bin 0, which gives us some safe values. We lose the highest OPP (1.5 GHz), but this was exactly the problematic one in the testing, so it's not a great loss. Once we have worked out what's really going on there, we can easily add a well tested OPP set later, to get the 1.5 GHz back. Will send a v5 shortly. Cheers, Andre