Re: [PATCH 3/3] ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/15/24 19:06, Andrew Jeffery wrote:
On Mon, 2024-04-15 at 09:59 -0500, Eddie James wrote:
On 4/14/24 19:54, Andrew Jeffery wrote:
On Fri, 2024-04-12 at 09:43 -0500, Eddie James wrote:
Set the new compatible string for Odyssey SBEFIFOs so that they
don't collect async FFDC.

Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx>
---
   .../dts/aspeed/aspeed-bmc-ibm-everest.dts     | 64 +++++++++----------
   .../arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 64 +++++++++----------
   2 files changed, 64 insertions(+), 64 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
index 214b2e6a4c6d..3a2bfdf035cb 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
@@ -2545,7 +2545,7 @@ scom500: scom@1000 {
   						};
sbefifo500: sbefifo@2400 {
-							compatible = "ibm,p9-sbefifo";
+							compatible = "ibm,ody-sbefifo";
   							reg = <0x2400 0x400>;
   							#address-cells = <1>;
   							#size-cells = <0>;
Bit of a drive-by comment as I'm not really holding any stakes here,
but did the hardware actually change?

Yes, the hardware did change in the Odyssey version.
Should there not be a new platform DTS then? Seems a bit puzzling, but
again this is a bit of a drive-by comment.


Ah, I should clarify. The SBE hardware was changed between P9/P10 and Odyssey versions. The Odyssey hasn't changed. The difference in the SBE wasn't apparent when we initially added support for Odyssey, so this is effectively a bug fix on the new hardware. There is no new platform.


Thanks,

Eddie



Andrew




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux