On 4/14/24 19:54, Andrew Jeffery wrote:
On Fri, 2024-04-12 at 09:43 -0500, Eddie James wrote:
Set the new compatible string for Odyssey SBEFIFOs so that they
don't collect async FFDC.
Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx>
---
.../dts/aspeed/aspeed-bmc-ibm-everest.dts | 64 +++++++++----------
.../arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 64 +++++++++----------
2 files changed, 64 insertions(+), 64 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
index 214b2e6a4c6d..3a2bfdf035cb 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
@@ -2545,7 +2545,7 @@ scom500: scom@1000 {
};
sbefifo500: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,ody-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
Bit of a drive-by comment as I'm not really holding any stakes here,
but did the hardware actually change?
Yes, the hardware did change in the Odyssey version.
Would it be better to request the behaviour by a property rather than
changing the compatible?
I'm not sure! In the past devicetree maintainers have objected to
behavioral type properties, like the FSI scan behavior one...
Thanks for the review!
Eddie
Andrew
