On Fri, Apr 5, 2024 at 2:04 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > DT schema expects node names to match certain. This fixes dtbs_check > warnings like: > > sparx5_pcb134_emmc.dtb: i2c0-emux@0: $nodename:0: 'i2c0-emux@0' does not match '^(i2c-?)?mux' > > and dtc W=1 warnings: > > sparx5_pcb134_board.dtsi:398.25-403.4: Warning (unique_unit_address_if_enabled): /axi@600000000/i2c0-imux@0: duplicate unit-address (also used in node /axi@600000000/i2c0-emux@0) > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > --- > > Changes in v2: > 1. None > --- > arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi > index e816e6e9d62d..cafec6ef0d0f 100644 > --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi > +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi > @@ -395,13 +395,13 @@ i2cmux_11: i2cmux-11-pins { > }; > > &axi { > - i2c0_imux: i2c0-imux@0 { > + i2c0_imux: i2c-mux-0 { Doesn't this introduce a new warning with simple-bus.yaml? These devices shouldn't be under an AXI bus which should require a unit-address. All the sft-eth* nodes have the same problem: axi@600000000: sfp-eth63: {'compatible': ['sff,sfp'], 'i2c-bus': [[91]], 'tx-disable-gpios': [[87, 31, 0, 1]], 'rate-select0-gpios': [[87, 31, 1, 0]], 'los-gpios': [[88, 31, 0, 0]], 'mod-def0-gpios': [[88, 31, 1, 1]], 'tx-fault-gpios': [[88, 31, 2, 0]], 'phandle': [[78]]} should not be valid under {'type': 'object'} Rob