> -----Original Message----- > From: Conor Dooley <conor@xxxxxxxxxx> > Sent: 2024年4月3日 2:17 > To: Frank Li <frank.li@xxxxxxx> > Cc: Hongxing Zhu <hongxing.zhu@xxxxxxx>; vkoul@xxxxxxxxxx; > kishon@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > kernel@xxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY > binding > > On Tue, Apr 02, 2024 at 10:23:45AM -0400, Frank Li wrote: > > On Tue, Apr 02, 2024 at 01:45:03PM +0800, Richard Zhu wrote: > > > Add i.MX8QM and i.MX8QXP HSIO SerDes PHY binding. > > > - Use the controller ID to specify which controller is binded to the > > > PHY. > > > - Introduce one HSIO configuration, mandatory required to set > > > "PCIE_AB_SELECT" and "PHY_X1_EPCS_SEL" during the initialization. > > > > > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx> > > > > You missed all conor's comments. > > Please double check v1's comments. > Hi Frank: Thanks a lot for your reminder. It's my fault that I missed this email. > > > + fsl,refclk-pad-mode: > > > + description: | > > > + Specifies the mode of the refclk pad used. It can be UNUSED(PHY > > > + refclock is derived from SoC internal source), INPUT(PHY refclock > > > + is provided externally via the refclk pad) or OUTPUT(PHY refclock > > > + is derived from SoC internal source and provided on the refclk pad). > > > + Refer include/dt-bindings/phy/phy-imx8-pcie.h for the constants > > > + to be used. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + enum: [ 0, 1, 2 ] > > > > I remember needn't enum because there are header file. > > Yah, specifically my comments about this property were missed and were > probably the most meaningful comments I left. Hi Conor: I'm so sorry about it. I made the mistake missing your last review email. Would follow your comments in next review cycle. Best Regards Richard Zhu > > Thanks for the reminder Frank.
