On Fri, Feb 09, 2024 at 10:16:25PM +0200, Dmitry Baryshkov wrote: > On Tue, 30 Jan 2024 at 08:55, Manivannan Sadhasivam > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > > > On Mon, Jan 29, 2024 at 11:44:15AM +0200, Dmitry Baryshkov wrote: > > > On Mon, 29 Jan 2024 at 09:55, Manivannan Sadhasivam > > > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > > > > > > > UFS host controller reset is required for the drivers to properly reset the > > > > controller. Hence, add it. > > > > > > > > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > > > > I think I had issues previously when I attempted to reset the > > > controller, but it might be because of the incomplete clocks > > > programming. Let met check whether it works first. > > > > > > > Sure. Please let me know. > > With the clocking fixes in place (I'll send them in a few minutes) and > with this patch the UFS breaks in the following way: > Was this further reviewed/investigated? What would you like me to do with this patch? Regards, Bjorn