On Mon, 29 Jan 2024 at 09:55, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > UFS host controller reset is required for the drivers to properly reset the > controller. Hence, add it. > > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> I think I had issues previously when I attempted to reset the controller, but it might be because of the incomplete clocks programming. Let met check whether it works first. > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 8d41ed261adf..a6592b3e2db7 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -2114,6 +2114,8 @@ ufshc: ufshc@624000 { > <&bimc MASTER_AMPSS_M0 &cnoc SLAVE_UFS_CFG>; > interconnect-names = "ufs-ddr", "cpu-ufs"; > > + resets = <&gcc GCC_UFS_BCR>; > + reset-names = "rst"; > lanes-per-direction = <1>; > #reset-cells = <1>; > status = "disabled"; > > -- > 2.25.1 > > -- With best wishes Dmitry