On 29/03/2024 20:48, Witold Sadowski wrote: > Add new bindings: > - mrvl,xspi-nor compatible string > Compatible string to enable Marvell XSPI modification > - Multiple PHY configuration registers > - base for xfer register set > > Signed-off-by: Witold Sadowski <wsadowski@xxxxxxxxxxx> Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > --- > .../devicetree/bindings/spi/cdns,xspi.yaml | 84 ++++++++++++++++++- > 1 file changed, 83 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > index eb0f92468185..d1fde8d4e9b8 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > @@ -20,23 +20,74 @@ allOf: > > properties: > compatible: > - const: cdns,xspi-nor > + - const: cdns,xspi-nor > + - const: mrvl,xspi-nor It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. There is a lot of things happening here, but I won't perform review if the code was never tested. Sorry, please test before sending. Best regards, Krzysztof
