On 30/03/2024 12:32, Krzysztof Kozlowski wrote: ... >> >> properties: >> compatible: >> - const: cdns,xspi-nor >> + - const: cdns,xspi-nor >> + - const: mrvl,xspi-nor > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. > > There is a lot of things happening here, but I won't perform review if > the code was never tested. Sorry, please test before sending. Hi, You did not address any of the comments and build issues neither here nor in previous mailings. Starting from 2022, all previous comments look ignored and then after some time you send another v1 expecting us to do review of the same code with the same issues. I gave it 1 month for some sort of response from you. None came. Therefore let's be clear: I will automatically NAK any further version you send, based on assumption you ignored entire existing feedback. Before sending any new patches for this XSPI, please first respond to numerous emails you already got (from the last two years). That's way we will know that reviewer's feedback is being addressed. Thank you for understanding. Best regards, Krzysztof
