On Fri, 22 Mar 2024, 11:33 Krzysztof Kozlowski, <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 21/03/2024 19:02, Kousik Sanagavarapu wrote: >> >> + spi-max-frequency: >> + $ref: /schemas/types.yaml#/definitions/uint32 > > No, drop. From which other SPI binding did you take it? I asked you to > look at existing code. Without this, "make dt_binding_check" would break though, right at the position in the example where "spi-max-frequency" is used. That was also the reason why additionalProperties was set to true in the last iteration, but after reading the doc more carefully I realized that was wrong after you pointed it out. I followed along bindings/spi/nvidia,tegra114-spi.yaml. (Sorry for the HTML mail ping, I'm replying from mobile)