On 21/03/2024 19:02, Kousik Sanagavarapu wrote: > Convert existing bindings of J-Core spi2 to dtschema. > > No new properties are added. > > Signed-off-by: Kousik Sanagavarapu <five231003@xxxxxxxxx> > --- > Changes since v1: > - changed the subject line to conform. > - dropped desc for "clock" and "clock-names" properties. > - cleaned up stuff. You miss many other changes... Some unusal properties appeared. ... > +--- > + > +$id: http://devicetree.org/schemas/spi/jcore,spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: J-Core SPI controller > + > +description: > + The J-Core "spi2" device is a PIO-based SPI controller which used to > + perform byte-at-a-time transfers between the CPU and itself. > + > +maintainers: > + - Kousik Sanagavarapu <five231003@xxxxxxxxx> > + > +allOf: > + - $ref: spi-controller.yaml# > + > +properties: > + compatible: > + const: jcore,spi2 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: ref_clk > + > + spi-max-frequency: > + $ref: /schemas/types.yaml#/definitions/uint32 No, drop. From which other SPI binding did you take it? I asked you to look at existing code. Best regards, Krzysztof