On Fri, Feb 23, 2024 at 04:17:31PM +0200, Laurent Pinchart wrote:
> On Fri, Feb 23, 2024 at 04:16:31PM +0200, Laurent Pinchart wrote:
> > Hi Alexander,
> >
> > Thank you for the patch.
> >
> > On Fri, Feb 23, 2024 at 03:04:44PM +0100, Alexander Stein wrote:
> > > In case the hardware only supports just one pipeline, allow using a
> > > single port node as well.
> >
> > This is frowned upon in DT bindings, as it makes them more complicated
> > for little gain. The recommendation is to always use a ports node if a
> > device can have multiple ports for at least one of its compatibles.
>
> And reading the cover letter, I see this causes warnings. I think we
> need guidance from Rob on this.
The warning is for:
ports {
port@0 {};
};
It should/could be changed like this to fix it:
ports {
port {};
};
But I've also said some warnings are guidance, not absolute. This is one
of them. Some devices have optional port@1. In those cases, switching
between 'port' and 'port@0' depending on 'port@1' makes little sense.
Rob
