Hi Alexander, Thank you for the patch. On Fri, Feb 23, 2024 at 03:04:44PM +0100, Alexander Stein wrote: > In case the hardware only supports just one pipeline, allow using a > single port node as well. This is frowned upon in DT bindings, as it makes them more complicated for little gain. The recommendation is to always use a ports node if a device can have multiple ports for at least one of its compatibles. > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/media/nxp,imx8-isi.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > index 4d5348d456a1f..f855f3cc91fea 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > @@ -53,6 +53,12 @@ properties: > power-domains: > maxItems: 1 > > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: | > + Port representing the Pixel Link input to the ISI. Used for > + single-pipeline models. The port shall have a single endpoint. > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > description: | > @@ -66,7 +72,6 @@ required: > - clocks > - clock-names > - fsl,blk-ctrl > - - ports > > allOf: > - if: > @@ -87,6 +92,11 @@ allOf: > port@1: false > required: > - port@0 > + oneOf: > + - required: > + - port > + - required: > + - ports > > - if: > properties: > @@ -106,6 +116,8 @@ allOf: > required: > - port@0 > - port@1 > + required: > + - ports > > additionalProperties: false > -- Regards, Laurent Pinchart
