Hello Jérémie, On Thu, 22 Feb 2024 11:31:16 +0100 Jérémie Dautheribes <jeremie.dautheribes@xxxxxxxxxxx> wrote: > The TI DP83826 PHY can operate in either MII mode or RMII mode. > By default, it is configured by straps. > It can also be configured by writing to the bit 5 of register 0x17 - RMII > and Status Register (RCSR). > > When phydev->interface is rmii, rmii mode must be enabled, otherwise > mii mode must be set. > This prevents misconfiguration of hw straps. > > Signed-off-by: Jérémie Dautheribes <jeremie.dautheribes@xxxxxxxxxxx> This looks good to me, Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>