On 20/02/2024 12:43, Krzysztof Kozlowski wrote: >>> >>> hisi_inno_phy_write_reg() should be moved to a separate bus driver. It's >>> bus-related, not phy. PHY driver should not care how to access the bus, >> >> So drivers are compatible or hardware? We talk about hardware, not >> drivers... >> >>> but the bus driver should. The PHY driver only needs to use regmap_* >>> APIs to "write BIT(2) to addr 6". >> >> Different programming interface, so not compatible. > > Although maybe I jumped to conclusions too fast. Do you claim that all > registers are the same? All the values, offsets, fields and masks? I still wait for the answer: yes or not, for above. Best regards, Krzysztof