On 19/02/2024 22:35, Yang Xiwen wrote: > On 2/20/2024 5:32 AM, Krzysztof Kozlowski wrote: >> On 19/02/2024 22:27, Yang Xiwen via B4 Relay wrote: >>> From: Yang Xiwen <forbidden405@xxxxxxxxxxx> >>> >>> Add missing compatible "hisilicon,hi3798mv100-usb2-phy" to compatible >>> list due to prior driver change. >>> >>> Also rename to hisilicon,inno-usb2-phy.yaml and add this name to >>> compatible lists. >>> >>> Fixes: 3940ffc65492 ("phy: hisilicon: Add inno-usb2-phy driver for Hi3798MV100") >>> Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx> >>> --- >>> .../bindings/phy/hisilicon,inno-usb2-phy.yaml | 95 ++++++++++++++++++++++ >>> .../devicetree/bindings/phy/phy-hisi-inno-usb2.txt | 71 ---------------- >>> 2 files changed, 95 insertions(+), 71 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml >>> new file mode 100644 >>> index 000000000000..1b57e0396209 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml >>> @@ -0,0 +1,95 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/phy/hisilicon,inno-usb2-phy.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: HiSilicon HiSTB SoCs INNO USB2 PHY device >>> + >>> +maintainers: >>> + - Yang Xiwen <forbidden405@xxxxxxxxxxx> >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - hisilicon,hi3798cv200-usb2-phy >>> + - hisilicon,hi3798mv100-usb2-phy >>> + - const: hisilicon,inno-usb2-phy >> According to your driver hisilicon,hi3798mv100-usb2-phy and >> hisilicon,inno-usb2-phy are not compatible. > Ah, i didn't pay too much attention to that. I should remove the entry > for hisilicon,inno-usb2-phy in the driver. Sorry for that. We don't talk here about driver, although I used the driver as proof or argument, because I don't have access to hardware datasheet (and no intention to look there). What I claim is these are not compatible, so respond to this argument, not some other one. Best regards, Krzysztof