On Thu, Feb 15, 2024 at 11:05:00AM +0100, Geert Uytterhoeven wrote: > On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > I think it would be good to have "# <display type> section" comments, > to make the grouping clear. > Else I wonder why "L" is sorted before "K" ;-) Makes sense, I added locally. ... > Shouldn't this (and PARPORT_PANEL and friends) be moved up, to the > character LCD section? I tried to be less invasive. ... > > obj-$(CONFIG_CHARLCD) += charlcd.o > > obj-$(CONFIG_HD44780_COMMON) += hd44780_common.o > > -obj-$(CONFIG_ARM_CHARLCD) += arm-charlcd.o > > +obj-$(CONFIG_HD44780) += hd44780.o > > +obj-$(CONFIG_LCD2S) += lcd2s.o > > obj-$(CONFIG_KS0108) += ks0108.o > > obj-$(CONFIG_CFAG12864B) += cfag12864b.o cfag12864bfb.o > > -obj-$(CONFIG_IMG_ASCII_LCD) += img-ascii-lcd.o > > -obj-$(CONFIG_HD44780) += hd44780.o > > -obj-$(CONFIG_HT16K33) += ht16k33.o > > -obj-$(CONFIG_PARPORT_PANEL) += panel.o > > -obj-$(CONFIG_LCD2S) += lcd2s.o > > obj-$(CONFIG_LINEDISP) += line-display.o > > +obj-$(CONFIG_IMG_ASCII_LCD) += img-ascii-lcd.o > > +obj-$(CONFIG_HT16K33) += ht16k33.o > > +obj-$(CONFIG_ARM_CHARLCD) += arm-charlcd.o > > +obj-$(CONFIG_PARPORT_PANEL) += panel.o > > IMHO it hurts to not sort Makefile entries alphabetically. I can add blank lines to follow the same grouping as in Kconfig. Would it work for you? -- With Best Regards, Andy Shevchenko
