Hi Andy,
On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> For better usability group the line display drivers together in Kconfig
> and Makefile.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -25,12 +25,6 @@ config CHARLCD
> This is some character LCD core interface that multiple drivers can
> use.
>
> -config LINEDISP
> - tristate "Character line display core support" if COMPILE_TEST
> - help
> - This is the core support for single-line character displays, to be
> - selected by drivers that use it.
> -
> config HD44780_COMMON
> tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST
> select CHARLCD
> @@ -52,6 +46,16 @@ config HD44780
> kernel and started at boot.
> If you don't understand what all this is about, say N.
>
> +config LCD2S
> + tristate "lcd2s 20x4 character display over I2C console"
> + depends on I2C
> + select CHARLCD
> + help
> + This is a driver that lets you use the lcd2s 20x4 character display
> + from Modtronix engineering as a console output device. The display
> + is a simple single color character display. You have to connect it
> + to an I2C bus.
> +
I think it would be good to have "# <display type> section" comments,
to make the grouping clear.
Else I wonder why "L" is sorted before "K" ;-)
> config KS0108
> tristate "KS0108 LCD Controller"
> depends on PARPORT_PC
> @@ -153,6 +157,12 @@ config CFAG12864B_RATE
> If you compile this as a module, you can still override this
> value using the module parameters.
>
> +config LINEDISP
> + tristate "Character line display core support" if COMPILE_TEST
> + help
> + This is the core support for single-line character displays, to be
> + selected by drivers that use it.
> +
> config IMG_ASCII_LCD
> tristate "Imagination Technologies ASCII LCD Display"
> depends on HAS_IOMEM
> @@ -177,16 +187,6 @@ config HT16K33
> Say yes here to add support for Holtek HT16K33, RAM mapping 16*8
> LED controller driver with keyscan.
>
> -config LCD2S
> - tristate "lcd2s 20x4 character display over I2C console"
> - depends on I2C
> - select CHARLCD
> - help
> - This is a driver that lets you use the lcd2s 20x4 character display
> - from Modtronix engineering as a console output device. The display
> - is a simple single color character display. You have to connect it
> - to an I2C bus.
> -
> config ARM_CHARLCD
> bool "ARM Ltd. Character LCD Driver"
> depends on PLAT_VERSATILE
Shouldn't this (and PARPORT_PANEL and friends) be moved up, to the
character LCD section?
> diff --git a/drivers/auxdisplay/Makefile b/drivers/auxdisplay/Makefile
> index 6968ed4d3f0a..43bad850481c 100644
> --- a/drivers/auxdisplay/Makefile
> +++ b/drivers/auxdisplay/Makefile
> @@ -5,12 +5,12 @@
>
> obj-$(CONFIG_CHARLCD) += charlcd.o
> obj-$(CONFIG_HD44780_COMMON) += hd44780_common.o
> -obj-$(CONFIG_ARM_CHARLCD) += arm-charlcd.o
> +obj-$(CONFIG_HD44780) += hd44780.o
> +obj-$(CONFIG_LCD2S) += lcd2s.o
> obj-$(CONFIG_KS0108) += ks0108.o
> obj-$(CONFIG_CFAG12864B) += cfag12864b.o cfag12864bfb.o
> -obj-$(CONFIG_IMG_ASCII_LCD) += img-ascii-lcd.o
> -obj-$(CONFIG_HD44780) += hd44780.o
> -obj-$(CONFIG_HT16K33) += ht16k33.o
> -obj-$(CONFIG_PARPORT_PANEL) += panel.o
> -obj-$(CONFIG_LCD2S) += lcd2s.o
> obj-$(CONFIG_LINEDISP) += line-display.o
> +obj-$(CONFIG_IMG_ASCII_LCD) += img-ascii-lcd.o
> +obj-$(CONFIG_HT16K33) += ht16k33.o
> +obj-$(CONFIG_ARM_CHARLCD) += arm-charlcd.o
> +obj-$(CONFIG_PARPORT_PANEL) += panel.o
IMHO it hurts to not sort Makefile entries alphabetically.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
