Hi, This adds Rockchip RK3588 USBDP PHY support, which is used for two of the three USB3 controllers in the RK3588 (the third one uses a different PHY, which is already supported). The USBDP PHY offers USB3 dual-role and DisplayPort. The driver and bindings being upstreamed contains the DP parts, but only USB3 has been tested by me (upstream does not yet have a DRM DP bridge driver for this platform). What has been tested by me: - USB3 Type A ports on Rock 5A, Rock 5B, EVB1 - USB Type C port on EVB1 in Host mode I did not yet include a patch to enable the Type-C from the Rock 5B, since that requires enabling proper support for the fusb302. Since the system is usually supplied via USB-C and without any battery backup, this easily results in system reset when the power-delivery negotiation happens. As this issue is independent from the USBDP PHY, I skipped enabling that port on Rock 5B for now. You can find a branch with these patches here: https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/commits/rk3588-usbdp The binding updates introduces one DT warning, for vo1 grf, which is already upstream and does not describe its clock. Fixing that requires this series, which adds the necessary clock ID for vo1: https://lore.kernel.org/linux-rockchip/20240126182919.48402-1-sebastian.reichel@xxxxxxxxxxxxx/T/#mbc27d87270f7f182fb85bf1ceaf03b902688cbb8 -- Sebastian Sebastian Reichel (10): dt-bindings: soc: rockchip: add clock to RK3588 VO grf dt-bindings: soc: rockchip: add rk3588 USB3 syscon dt-bindings: phy: add rockchip usbdp combo phy document phy: rockchip: add usbdp combo phy driver arm64: defconfig: enable Rockchip Samsung USBDP PHY arm64: dts: rockchip: add USBDP phys on rk3588 arm64: dts: rockchip: add USB3 DRD controllers on rk3588 arm64: dts: rockchip: add USB3 to rk3588-evb1 arm64: dts: rockchip: add upper USB3 port to rock-5a arm64: dts: rockchip: add lower USB3 port to rock-5b .../bindings/phy/phy-rockchip-usbdp.yaml | 166 ++ .../devicetree/bindings/soc/rockchip/grf.yaml | 21 + .../boot/dts/rockchip/rk3588-evb1-v10.dts | 151 ++ .../boot/dts/rockchip/rk3588-rock-5b.dts | 21 + arch/arm64/boot/dts/rockchip/rk3588.dtsi | 82 + .../boot/dts/rockchip/rk3588s-rock-5a.dts | 22 + arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 95 + arch/arm64/configs/defconfig | 1 + drivers/phy/rockchip/Kconfig | 12 + drivers/phy/rockchip/Makefile | 1 + drivers/phy/rockchip/phy-rockchip-usbdp.c | 1641 +++++++++++++++++ 11 files changed, 2213 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml create mode 100644 drivers/phy/rockchip/phy-rockchip-usbdp.c -- 2.43.0
