Re: [PATCH v6 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Geert,

On 08.02.2024 14:53, Geert Uytterhoeven wrote:
> Hi Claudiu,
> 
> On Thu, Feb 8, 2024 at 1:26 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
>> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>>
>> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
>> clocks are enabled though pm_runtime_* specific APIs). To avoid building
>> a driver that doesn't work make explicit the dependency on CONFIG_PM.
>>
>> Suggested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>> ---
>>
>> Changes in v6:
>> - update patch description
>> - fixed the dependency on COMPILE_TEST previously introduced
> 
> Thanks for the update!
> 
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
>>  config RENESAS_RZG2LWDT
>>         tristate "Renesas RZ/G2L WDT Watchdog"
>>         depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
>> +       depends on PM
> 
> depends on PM || COMPILE_TEST

Isn't "depends on PM" enough? As of [1] ("If multiple dependencies are
defined, they are connected with '&&'") the above:

depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
depends on PM

are translated into:
depends on (ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST) && PM

Please let me know if I'm wrong.

Thank you,
Claudiu Beznea

[1] https://www.kernel.org/doc/html/next/kbuild/kconfig-language.html

> 
>>         select WATCHDOG_CORE
>>         help
>>           This driver adds watchdog support for the integrated watchdogs in the
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux