On 02/02/2024 11:53, Conor Dooley wrote: > On Fri, Feb 02, 2024 at 11:36:55AM +0200, Roger Quadros wrote: >> >> >> On 01/02/2024 21:13, Conor Dooley wrote: >>> On Thu, Feb 01, 2024 at 12:35:22PM -0600, Bin Liu wrote: >>>> On Thu, Feb 01, 2024 at 06:18:05PM +0000, Conor Dooley wrote: >>>>> On Thu, Feb 01, 2024 at 06:15:20PM +0000, Conor Dooley wrote: >>>>>> On Thu, Feb 01, 2024 at 02:03:31PM +0200, Roger Quadros wrote: >>>>>>> So far this was not required but due to the newly identified >>>>>>> Errata i2409 [1] we need to poke this register space. >>>>>>> >>>>>>> [1] https://www.ti.com/lit/er/sprz487d/sprz487d.pdf >>>>>>> >>>>>>> Signed-off-by: Roger Quadros <rogerq@xxxxxxxxxx> >>>>>> >>>>>> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >>>>> >>>>> Actually, where is the user for this that actually pokes the register >>>>> space? >> >> https://lore.kernel.org/all/20240201121220.5523-5-rogerq@xxxxxxxxxx/ >> >>>>> You're adding another register region, so I went to check how you were >>>>> handling that in drivers, but there's no driver patch. >>>> >>>> See Roger's another patch set 'Add workaround for Errata i2409' posted >>>> on 16th. >>> >>> This patch should be with that series, not with these dts patches. >>> >> >> Why not? There should be no dependency between DTS and driver implementation. >> >> As DTS and driver will be merged by separate maintainers I thought it >> would be easier for maintainers this way. > > dts and driver might be merged by different people, but dt-bindings and > drivers are merged by the same people. This is a bindings patch, not a If we do that then I get a bunch of dtbs_check warnings dwc3-usb@f900000: reg: [[0, 261095424, 0, 2048], [0, 261128192, 0, 1024]] is too long > dts patch. Look at what get_maintainer says for this file: > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (supporter:USB SUBSYSTEM) > Rob Herring <robh+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > Conor Dooley <conor+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > Aswath Govindraju <a-govindraju@xxxxxx> (in file) > linux-usb@xxxxxxxxxxxxxxx (open list:USB SUBSYSTEM) > devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > linux-kernel@xxxxxxxxxxxxxxx (open list) > Greg and linux-usb are on there, but you have not CCed them. My bad. Will be more careful next time. > > Being with the driver also allows bindings maintainers to check that you > don't break backwards compatibility. It also prevents me having to ask > for the driver patch, then be given just a subject line that I have to > go and look up myself! > Sorry about that. It took a bit longer but I did point you directly to the patch on lore.kernel.org. -- cheers, -roger
