On 01/02/2024 21:13, Conor Dooley wrote: > On Thu, Feb 01, 2024 at 12:35:22PM -0600, Bin Liu wrote: >> On Thu, Feb 01, 2024 at 06:18:05PM +0000, Conor Dooley wrote: >>> On Thu, Feb 01, 2024 at 06:15:20PM +0000, Conor Dooley wrote: >>>> On Thu, Feb 01, 2024 at 02:03:31PM +0200, Roger Quadros wrote: >>>>> So far this was not required but due to the newly identified >>>>> Errata i2409 [1] we need to poke this register space. >>>>> >>>>> [1] https://www.ti.com/lit/er/sprz487d/sprz487d.pdf >>>>> >>>>> Signed-off-by: Roger Quadros <rogerq@xxxxxxxxxx> >>>> >>>> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >>> >>> Actually, where is the user for this that actually pokes the register >>> space? https://lore.kernel.org/all/20240201121220.5523-5-rogerq@xxxxxxxxxx/ >>> You're adding another register region, so I went to check how you were >>> handling that in drivers, but there's no driver patch. >> >> See Roger's another patch set 'Add workaround for Errata i2409' posted >> on 16th. > > This patch should be with that series, not with these dts patches. > Why not? There should be no dependency between DTS and driver implementation. As DTS and driver will be merged by separate maintainers I thought it would be easier for maintainers this way. -- cheers, -roger