On Thu, Feb 01, 2024 at 06:18:05PM +0000, Conor Dooley wrote: > On Thu, Feb 01, 2024 at 06:15:20PM +0000, Conor Dooley wrote: > > On Thu, Feb 01, 2024 at 02:03:31PM +0200, Roger Quadros wrote: > > > So far this was not required but due to the newly identified > > > Errata i2409 [1] we need to poke this register space. > > > > > > [1] https://www.ti.com/lit/er/sprz487d/sprz487d.pdf > > > > > > Signed-off-by: Roger Quadros <rogerq@xxxxxxxxxx> > > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Actually, where is the user for this that actually pokes the register > space? > You're adding another register region, so I went to check how you were > handling that in drivers, but there's no driver patch. See Roger's another patch set 'Add workaround for Errata i2409' posted on 16th. -Bin. > > > > > > > --- > > > > > > Notes: > > > Changelog: > > > > > > v3 - new patch > > > > > > Documentation/devicetree/bindings/usb/ti,am62-usb.yaml | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > > index fec5651f5602..c02d9d467d9c 100644 > > > --- a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml > > > @@ -14,7 +14,9 @@ properties: > > > const: ti,am62-usb > > > > > > reg: > > > - maxItems: 1 > > > + items: > > > + - description: USB CFG register space > > > + - description: USB PHY2 register space > > > > > > ranges: true > > > > > > @@ -82,7 +84,8 @@ examples: > > > > > > usbss1: usb@f910000 { > > > compatible = "ti,am62-usb"; > > > - reg = <0x00 0x0f910000 0x00 0x800>; > > > + reg = <0x00 0x0f910000 0x00 0x800>, > > > + <0x00 0x0f918000 0x00 0x400>; > > > > Why the double zeros btw? > > > > Cheers, > > Conor. > > > > > clocks = <&k3_clks 162 3>; > > > clock-names = "ref"; > > > ti,syscon-phy-pll-refclk = <&wkup_conf 0x4018>; > > > -- > > > 2.34.1 > > > > >
