RE: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Biju Das
> Sent: Friday, February 2, 2024 8:03 AM
> Subject: RE: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM
> 
> Hi Claudiu Beznea,
> 
> > -----Original Message-----
> > From: Claudiu <claudiu.beznea@xxxxxxxxx>
> > Sent: Friday, February 2, 2024 7:59 AM
> > Subject: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM
> >
> > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> >
> > The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
> > clocks are enabled though pm_runtime_* specific APIs). To avoid
> > building a driver that doesn't work make it depend on CONFIG_PM.
> >
> > Suggested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v3:
> > - make driver depend on PM; with that the "unmet direct dependency"
> >   Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >   was also fixed
> > - adapt commit message
> >
> > Changes in v2:
> > - this patch is new
> >
> >  drivers/watchdog/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index
> > 7d22051b15a2..c9abe8f307bb 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -910,7 +910,7 @@ config RENESAS_RZN1WDT
> >
> >  config RENESAS_RZG2LWDT
> >  	tristate "Renesas RZ/G2L WDT Watchdog"
> > -	depends on ARCH_RENESAS || COMPILE_TEST
> > +	depends on (ARCH_RENESAS && PM) || COMPILE_TEST
> 
> Since you are touching here, maybe ARCH_RZG2L?? like other RZ/G2L drivers.

Also RZ/V2M "ARCH_R9A09G011" as both these families using same driver.

Cheers,
Biju





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux