Hi Rob, On Thu, Feb 1, 2024 at 11:11 PM Rob Herring <robh@xxxxxxxxxx> wrote: > On Thu, Feb 01, 2024 at 04:58:41PM +0100, Geert Uytterhoeven wrote: > > make dtbs_check: > > > > arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb: regulator-vccq-sdhi0: Unevaluated properties are not allowed ('gpios-states', 'states' were unexpected) > > from schema $id: http://devicetree.org/schemas/regulator/gpio-regulator.yaml# > > Unevaluated properties warning here is not interesting. If a property > fails validation, then it is considered unevaluated. It's that warning > which is interesting: > > arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb: regulator-vccq-sdhi0: gpios-states:0: [1] is too short > from schema $id: http://devicetree.org/schemas/regulator/gpio-regulator.yaml# Oops (again, I'm afraid my mind is already living at FOSDEM ;-), I copy-'n-pasted the wrong message... > > The number of items in "gpios-states" must match the number of items in > > "gpios", so their limits should be identical. > > > > The number of items in "states" must lie within the range from zero up > > to 2^{number of gpios}. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > The second issue did not cause any dtbs_check errors? > > I'm not seeing 'states' fail, but it looks like you did? Is that the > issue you mean? Looks like in the matrix case, we're now setting > minItems if unspecified. No, I did not see states fail, only gpios-states. Hence "the second issue did not cause errors". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds