Hi Jason, Andrew,
On 25/01/2015 20:18, Jason Cooper wrote:
> On Sun, Jan 25, 2015 at 06:09:25PM +0100, Andrew Lunn wrote:
>>>>>> +
>>>>>> + power {
>>>>>> + label = "mamba:white:power";
>>>>>
>>>>> Please replace this mamba with wrt1900ac. It is a property of the
>>>>> device, not the board. Another device using the mamba board may use it
>>>>> differently.
>>>>>
>>>>
>>>> See above.
>>>
>>> The LED should be named by the device, not the platform. If OpenWRT
>>> userspace already expects "mamba" in here, I guess we are stuck with
>>> it. If not, call it "wrt1900ac:white:power".
>>
>> Hi Sebastian
>>
>> We have some flexibility here. There is the mantra, don't break
>> userspace, but that only applies once code has reached mainline.
>
> Full agree.
>
>> If it is decided that mamba is used everywhere, then it should be used
>> here. If wrt1900ac is used, then i would like to see this LED named
>> wrt1900ac.
>
> I think the main problem here is that we are trying to predict the
> future decisions of an opaque entity (Linksys). We can't. All we can
> do is be specific about what we have before us today. Then we can
> create a new compatible string in the future that reflects the
> differences post-opaque-entity-decisions.
>
> To that end, engineering is considerably more reliable than marketing.
> So I would be inclined to use 'mamba' for this board. If Linksys
> creates a variant of this board and keeps the board name, then we can
> call it 'mamba-v2'. Or, 'mamba-revB' if that's on the silk layer.
>
> At any rate, unless the DT maintainers disagree, compatible strings
> should reflect engineering attributes, and 'model' should reflect
> marketing names users would be familiar with.
>
> So...
>
> model = "Linksys WRT1900AC";
> compatible = "linksys,mamba", "...";
>
> ...
>
> power {
> label = "mamba:white:power";
>
Until now for the Armada 37x/38x/XP/ evaluation board we used the marketing
(or something close to it) as compatible name and the model was used for the
extensive marketing name. It would have made more sens to use the "engineering"
name as compatible string as Jason suggested. For this reason I agree with this
binding but I don't have a strong opinion on it.
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
