> >>>+ > >>>+ power { > >>>+ label = "mamba:white:power"; > >> > >>Please replace this mamba with wrt1900ac. It is a property of the > >>device, not the board. Another device using the mamba board may use it > >>differently. > >> > > > >See above. > > The LED should be named by the device, not the platform. If OpenWRT > userspace already expects "mamba" in here, I guess we are stuck with > it. If not, call it "wrt1900ac:white:power". Hi Sebastian We have some flexibility here. There is the mantra, don't break userspace, but that only applies once code has reached mainline. We don't have to be compatible with OpenWRT, if we feel it would be wrong to do so. OpenWRT should be well aware of the risk of not "Upstream first". However, if it does not cost us anything, we can be compatible. I think Android is another good example. Some code has been accepted into mainline as is, other parts have been re-written with different APIs. If it is decided that mamba is used everywhere, then it should be used here. If wrt1900ac is used, then i would like to see this LED named wrt1900ac. What you don't see in this dts file is the other 8 or so LEDs, which are connected to an I2c LED driver. A first version of the kernel driver has now been merged, the DT binding is stable, so we should add these LEDs to this dts file. But we should be consistent with the naming. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html