On Sun, Jan 25, 2015 at 06:09:25PM +0100, Andrew Lunn wrote:
> > >>>+
> > >>>+ power {
> > >>>+ label = "mamba:white:power";
> > >>
> > >>Please replace this mamba with wrt1900ac. It is a property of the
> > >>device, not the board. Another device using the mamba board may use it
> > >>differently.
> > >>
> > >
> > >See above.
> >
> > The LED should be named by the device, not the platform. If OpenWRT
> > userspace already expects "mamba" in here, I guess we are stuck with
> > it. If not, call it "wrt1900ac:white:power".
>
> Hi Sebastian
>
> We have some flexibility here. There is the mantra, don't break
> userspace, but that only applies once code has reached mainline.
Full agree.
> If it is decided that mamba is used everywhere, then it should be used
> here. If wrt1900ac is used, then i would like to see this LED named
> wrt1900ac.
I think the main problem here is that we are trying to predict the
future decisions of an opaque entity (Linksys). We can't. All we can
do is be specific about what we have before us today. Then we can
create a new compatible string in the future that reflects the
differences post-opaque-entity-decisions.
To that end, engineering is considerably more reliable than marketing.
So I would be inclined to use 'mamba' for this board. If Linksys
creates a variant of this board and keeps the board name, then we can
call it 'mamba-v2'. Or, 'mamba-revB' if that's on the silk layer.
At any rate, unless the DT maintainers disagree, compatible strings
should reflect engineering attributes, and 'model' should reflect
marketing names users would be familiar with.
So...
model = "Linksys WRT1900AC";
compatible = "linksys,mamba", "...";
...
power {
label = "mamba:white:power";
The most deceptive part of this is that 'wrt1900ac' sounds *so* specific
that we are inclined to trust it and use it. But beware, marketing folks
have never heard of version control, compatibility, or consistency.
They are more likely to pull a Crazy Ivan [1] on us than Ivan himself. :-)
thx,
Jason.
[1] https://en.wikipedia.org/wiki/Crazy_Ivan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
