Hi, On Fri, 26 Jan 2024 at 21:47, Conor Dooley <conor@xxxxxxxxxx> wrote: > > Hey, > > On Fri, Jan 26, 2024 at 05:25:08PM +0530, Naresh Solanki wrote: > > Add #io-channel-cells expected by driver. i.e., below is the message > > seen in kernel log: > > OF: /iio-hwmon: could not get #io-channel-cells for /voltage_divider1 > > > > > TEST=Run below command & make sure there is no error: > > make DT_CHECKER_FLAGS=-m dt_binding_check -j1 > > This shouldn't be in the commit message. ok Will remove. > > > > > Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml > > index dddf97b50549..b4b5489ad98e 100644 > > --- a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml > > +++ b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml > > @@ -39,6 +39,9 @@ properties: > > description: | > > Channel node of a voltage io-channel. > > > > + '#io-channel-cells': > > + const: 1 > > The example in this binding looks like the voltage-divider is intended > to be an "IIO consumer" but "#io-channels-cells" is an "IIO provider" > property. > > Are you sure this is correct? I'm not aware that #io-channels-cells is only for IIO provider. But I do get some kernel message as mention in commit messages if this is specified in DT. Regards, Naresh > > > + > > output-ohms: > > description: > > Resistance Rout over which the output voltage is measured. See full-ohms. > > > > base-commit: ecb1b8288dc7ccbdcb3b9df005fa1c0e0c0388a7 > > -- > > 2.42.0 > >