On Wed, Jan 21, 2015 at 08:46:29AM +0100, Robert Jarzmik wrote: > Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> writes: > > > What I'd suggest (and always have done) is: > > > > dev_err(&pdev->dev, "couldn't request main irq%d: %d\n", > > irq, ret); > I like it, it's even more compact, I'll use it for next patch version. BTW, this is an example why I have the policy of always ensuring that the kernel messages print sufficient diagnostics. Right now, I have a problem - since I rebooted my firewall a few nights ago, I now get on one of my machines: rt6_redirect: source isn't a valid nexthop for redirect target and it spews that for a few minutes every 26 hours or so. No further information, and it leaves you wondering "well, what was the invalid next hop? What was the source?" Pretty much the only way to try and find out is to leave a tcpdump or wireshark running for 24 hours to try and get a dump - which is not that easy if you don't have lots of disk space. So, right now, I have no way to diagnose the above. If it printed that information, then I'd be able to see what the addresses were, and I'd probably be able to come up with a tcpdump filter which didn't involve logging all IPv6 traffic. Kernel messages need to be smart. If not, they might as well just be "The kernel encountered a problem. Abort, Retry or Fail?" -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
