On Mon, 19 Jan 2015, Robert Jarzmik wrote:
> Lee Jones <lee.jones@xxxxxxxxxx> writes:
> > On Fri, 16 Jan 2015, Robert Jarzmik wrote:
[...]
> >> + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> >
> > platform_get_irq()?
> No. I need the flags.
Where are they used?
[...]
> >> + if (ret) {
> >> + dev_err(&pdev->dev, "Couldn't request main irq : ret = %d\n",
> >> + ret);
> >
> > I'm not keen on this type of formatting. Besides the system will
> > print out the returned error on failure.
> Well, it will print -EINVAL or -ENODEV. When I'll receive an request on the
> driver with -ENODEV, how will I know it will come from this request_irq() or
> another part of the code ... Well I can remove it if you want, but I think it's
> an error.
I'm not asking you to remove the entire message, just the junk at the
end.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
