On 27/12/2023 08:04, Ding, Shenghao wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Friday, December 22, 2023 1:32 AM >> To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; Ding, Shenghao >> <shenghao-ding@xxxxxx> >> Cc: broonie@xxxxxxxxxx; conor+dt@xxxxxxxxxx; robh+dt@xxxxxxxxxx; Lu, >> Kevin <kevin-lu@xxxxxx>; Xu, Baojun <baojun.xu@xxxxxx>; >> devicetree@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; pierre- >> louis.bossart@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; linux- >> sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> liam.r.girdwood@xxxxxxxxx; soyer@xxxxxx; tiwai@xxxxxxx; Gupta, Peeyush >> <peeyush@xxxxxx>; Navada Kanyana, Mukund <navada@xxxxxx> >> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 >> from yaml >> >> On 21/12/2023 16:50, Andy Shevchenko wrote: >>> On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote: >>>> Remove tas2563 from tas2562, it will be supported in tas2781 to >>>> better support dsp mode. >>> >>> DSP >>> >>> Shouldn't this patch go after the actual change happen? >> >> I would squash both, so device documentation does not disappear. > I do not fully understand "squash both", do you mean still to keep ti,tas2563 in tas2562.yaml? I meant to squash both binding patches (git help rebase). Best regards, Krzysztof