On Wed, Dec 20, 2023 at 4:29 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 20/12/2023 10:17, Binbin Zhou wrote:
> > On Tue, Dec 19, 2023 at 9:37 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >>
> >> On 18/12/2023 02:52, Binbin Zhou wrote:
> >>> Add DeviceTree file for Loongson-2K0500 processor, which integrates one
> >>> 64-bit dual emission superscalar LA264 processor core.
> >>>
> >>> Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
> >>> ---
> >>> arch/loongarch/boot/dts/Makefile | 2 +
> >>> .../boot/dts/loongson-2k0500-ref.dts | 89 ++++++
> >>> arch/loongarch/boot/dts/loongson-2k0500.dtsi | 274 ++++++++++++++++++
> >>> 3 files changed, 365 insertions(+)
> >>> create mode 100644 arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> >>> create mode 100644 arch/loongarch/boot/dts/loongson-2k0500.dtsi
> >>>
> >>> diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile
> >>> index 1e24cdb5180a..aa0b21d73d4e 100644
> >>> --- a/arch/loongarch/boot/dts/Makefile
> >>> +++ b/arch/loongarch/boot/dts/Makefile
> >>> @@ -1,3 +1,5 @@
> >>> # SPDX-License-Identifier: GPL-2.0-only
> >>>
> >>> +dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb
> >>> +
> >>> obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME))
> >>> diff --git a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> >>> new file mode 100644
> >>> index 000000000000..52483127a419
> >>> --- /dev/null
> >>> +++ b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> >>> @@ -0,0 +1,89 @@
> >>> +// SPDX-License-Identifier: GPL-2.0
> >>> +/*
> >>> + * Copyright (C) 2023 Loongson Technology Corporation Limited
> >>> + */
> >>> +
> >>> +/dts-v1/;
> >>> +
> >>> +#include "loongson-2k0500.dtsi"
> >>> +
> >>> +/ {
> >>> + compatible = "loongson,ls2k0500-ref", "loongson,ls2k0500";
> >>> + model = "Loongson-2K0500 Reference Board";
> >>> +
> >>> + aliases {
> >>> + ethernet0 = &gmac0;
> >>> + ethernet1 = &gmac1;
> >>> + serial0 = &uart0;
> >>> + };
> >>> +
> >>> + chosen {
> >>> + stdout-path = "serial0:115200n8";
> >>> + bootargs = "console=ttyS0,115200";
> >>
> >> You received here comments already:
> >> https://lore.kernel.org/all/3543cbf9-d259-8d0f-e78e-d8d5e3f501de@xxxxxxxxxx/
> >>
> >> Don't waste our time to re-review the same mistakes over and over again.
> >>
> >>
> > Hi Krzysztof:
> >
> > I am sorry for this, I misunderstood before that `earlycon` is not allowed.
> > BTW, is there a note about not using the `bootargs` attribute? I
> > didn't find it in the Documentation.
>
> This is a common sense, not a "note". If you think otherwise, please
> provide me the reasons why duplicated information is necessary in this
> particular case.
>
Hi Krzysztof:
I checked the relevant code and the console parameter is already in
the stdout-path property. Sorry I didn't get the logic here before,
thanks for pointing it out.
The previous attempt to leave it because it would affect the boot
cmdline proved not to be the right way to do it, so we fixed it some
other way.
Anyway, I'll fix it in the next patch set.
Thanks.
Binbin
> >
> >>
> >> ...
> >>
> >>> +
> >>> + i2c@1ff4a800 {
> >>> + compatible = "loongson,ls2k-i2c";
> >>> + reg = <0x0 0x1ff4a800 0x0 0x0800>;
> >>> + interrupt-parent = <&eiointc>;
> >>> + interrupts = <19>;
> >>> + status = "disabled";
> >>> + };
> >>> +
> >>> + pmc: power-management@1ff6c000 {
> >>> + compatible = "loongson,ls2k0500-pmc", "syscon";
> >>
> >> It does not look like you tested the DTS against bindings. Please run
> >> `make dtbs_check W=1` (see
> >> Documentation/devicetree/bindings/writing-schema.rst or
> >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> >> for instructions).
> >
> > Emm...
> > Here is the compatible description from the latest kernel:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml#n13
> >
> > I think this compatible should be fine, also, I ensure that `make
> > dtbs_check W=1` is fine before committing.
>
> Hm, that's fine then.
>
> Best regards,
> Krzysztof
>
