On Tue, 12 Dec 2023 21:09:45 +0300 Maxim Kiselev <bigunclemax@xxxxxxxxx> wrote: Hi Maksim, sorry for the delay. > пн, 11 дек. 2023 г. в 02:48, Andre Przywara <andre.przywara@xxxxxxx>: > > > > On Sat, 9 Dec 2023 13:44:34 +0300 > > Maksim Kiselev <bigunclemax@xxxxxxxxx> wrote: > > > > Hi Maksim, > > > > > Hi Martin, Andre. > > > > > > May I inquire? Why do we need a separate sun50i_h616_ths_calibrate() > > > function? Why can't we just extend an existing sun50i_h6_ths_calibrate()? > > > > > > At my glance the calculations in both functions are the same. We just > > > need to handle a special case for the 4th sensor. > > > > You seem to be right, they are indeed the same, just written slightly > > differently. Do you already have any patches that unify that? > > No, I don't have any patches for that yet. But I can do it if you told > me where to > send the patch. Should I put it here as a reply? Can you make one patch on top of mainline, that prepares the existing sun50i_h6_ths_calibrate() function to deal with four sensors? I would then include this patch of yours in the next submission, and put Martin's H616 patch (now probably just the struct ths_thermal_chip) on top then. Please send this patch just to the list (CC:ing people like Martin and me), starting a new thread. Many thanks, Andre > > I don't know if Martin or I find time to do it this week, but we could > > also optimise this later. > > > > Cheers, > > Andre > > Best regards, > Maksim
