Re: [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller

Subject: Re: [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller
From: Maksim Kiselev <bigunclemax@xxxxxxxxx>
Date: Sat, 9 Dec 2023 13:44:34 +0300
Cc: anarsoul@xxxxxxxxx, bob@xxxxxxxxxxxxxxxxx, conor+dt@xxxxxxxxxx, daniel.lezcano@xxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, jernej.skrabec@xxxxxxxxx, krzysztof.kozlowski+dt@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-sunxi@xxxxxxxxxxxxxxx, lukasz.luba@xxxxxxx, martin.botka@xxxxxxxxxxxxxx, rafael@xxxxxxxxxx, robh+dt@xxxxxxxxxx, rui.zhang@xxxxxxxxx, samuel@xxxxxxxxxxxx, tiny.windzz@xxxxxxxxx, wens@xxxxxxxx
In-reply-to: <20231128005849.19044-6-andre.przywara@arm.com>
User-agent: Mozilla Thunderbird

Hi Martin, Andre.

May I inquire? Why do we need a separate sun50i_h616_ths_calibrate()function? Why can't we just extend an existing sun50i_h6_ths_calibrate()?

At my glance the calculations in both functions are the same. We justneed to handle a special case for the 4th sensor.


Best regards,
Maksim

Follow-Ups:
- Re: [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller
  - From: Andre Przywara

References:
- [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller
  - From: Andre Przywara