On 13/12/2023 00:28, Frank Li wrote: >>> items: >>> @@ -90,6 +91,22 @@ required: >>> allOf: >>> - $ref: /schemas/pci/snps,dw-pcie.yaml# >>> - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - fsl,imx95-pcie >>> + then: >>> + properties: >>> + reg: >>> + minItems: 4 >>> + reg-names: >>> + items: >>> + - const: dbi >>> + - const: serdes >> >> Did you test this? It should fail because 'serdes' would need to be >> added to snps,dw-pcie.yaml. > > I run "make dt_binding_check DT_SCHEMA_FILES=/pci/", no error report. > And PCIe function can work. Did you test your DTS. The answer is, like Rob suspected: no, you did not test it. This fails. Best regards, Krzysztof