On 12/12/2023 11:07, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC NPCM BIOS Post > Code (BPC). > > The NPCM BPC monitoring two configurable I/O addresses written by the > host on the bus. > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > --- It's v2, so changelog? > .../soc/nuvoton/nuvoton,npcm-bpc.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-bpc.yaml > > diff --git a/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-bpc.yaml b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-bpc.yaml > new file mode 100644 > index 000000000000..30033cdac8f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-bpc.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/nuvoton/nuvoton,npcm-bpc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton BMC NPCM BIOS Post Code (bpc) controller s/bpc/BPC/ > + > +maintainers: > + - Tomer Maimon <tmaimon77@xxxxxxxxx> > + > +description: > + Nuvoton BMC NPCM BIOS Post Code (BPC) monitoring two configurable I/O > + addresses written by the host on the bus, the capture data stored in > + 128-word FIFO. > + > + NPCM BPC supports capture double words, when using capture > + double word only I/O address 1 is monitored. > + > +properties: > + compatible: > + enum: > + - nuvoton,npcm750-bpc > + - nuvoton,npcm845-bpc Your device driver suggests these are compatible, so express it in the bindings and modify driver respectively. > + > + reg: > + maxItems: 1 > + Best regards, Krzysztof