On 11/12/2023 22:58, Frank Li wrote: > Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string. > Add reg-name: "atu", "dbi2", "dma" and "serdes". > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > > Notes: > Change from v1 to v3 > - new patches at v3 > > .../bindings/pci/fsl,imx6q-pcie-ep.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > index ee155ed5f1811..36d8f117fdfb3 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > @@ -22,6 +22,7 @@ properties: > - fsl,imx8mm-pcie-ep > - fsl,imx8mq-pcie-ep > - fsl,imx8mp-pcie-ep > + - fsl,imx95-pcie-ep > > reg: > minItems: 2 > @@ -62,11 +63,30 @@ required: > allOf: > - $ref: /schemas/pci/snps,dw-pcie-ep.yaml# > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx95-pcie-ep > + then: > + properties: > + reg: > + minItems: 6 > + reg-names: > + items: > + - const: dbi > + - const: atu > + - const: dbi2 > + - const: serdes > + - const: dma > + - const: addr_space Again, was it tested? Testing in this context means: bindings check pass (dt_binding_check) and all your DTS pass, or at least do not introduce any new warning. Best regards, Krzysztof