> +properties: > + qca,led-active-high: > + description: Set all the LEDs to active high to be turned on. > + type: boolean I would of expected active high is the default. An active low property would make more sense. It should also be a generic property, not a vendor property. As such, we either want the phylib core to parse it, or the LED core. Andrew