On 11/12/2023 13:18, Christian Marangi wrote: >>> + QCA808X PHYs can have up to 3 LEDs attached. >>> + All 3 LEDs are disabled by default. >>> + 2 LEDs have dedicated pins with the 3rd LED having the >>> + double function of Interrupt LEDs/GPIO or additional LED. >>> + >>> + By default this special PIN is set to LED function. >>> + >>> +allOf: >>> + - $ref: ethernet-phy.yaml# >>> + >>> +select: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - ethernet-phy-id004d.d101 >> >> I have impression that this is continuation of some other patchset... >> Anyway, id004d.d101 is specific to QCA808x? >> > > I used enum assuming eventually more qca808x PHY will come... Yes that > ID is specific and it's the id of QCA8081. Better to use const? No, it is fine. I just wanted to be sure that this will not be matched by other bindings. Best regards, Krzysztof
