On Mon, Dec 11, 2023 at 04:44:06PM +0100, Andrew Lunn wrote: > > +properties: > > + qca,led-active-high: > > + description: Set all the LEDs to active high to be turned on. > > + type: boolean > > I would of expected active high is the default. An active low property > would make more sense. It should also be a generic property, not a > vendor property. As such, we either want the phylib core to parse it, > or the LED core. > Mhhh with a generic property and LED core or phylib handling it... How it would work applying that setting on PHY side? Adding the check to the set_brightness set_blink hw_control API? -- Ansuel