Hi Krzysztof：
At 2023-12-10 19:12:15, "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>On 10/12/2023 09:06, Andy Yan wrote:
>> Cool Pi CM5 EVB is a board based on rk3588.
>>
>> Specification:
>> - Rockchip RK3588
>> - LPDDR4 2/4/8/16 GB
>> - TF scard slot
>> - eMMC 8/32/64/128 GB module
>> - Gigabit ethernet x 1 with PHY YT8531
>> - Gigabit ethernet x 1 drived by PCIE with YT6801S
>> - HDMI Type A out x 2
>> - HDMI Type D in x 1
>> - USB 2.0 Host x 2
>> - USB 3.0 OTG x 1
>> - USB 3.0 Host x 1
>> - PCIE M.2 E Key for Wireless connection
>> - PCIE M.2 M Key for NVME connection
>> - 40 pin header
>
>
>> +
>> + backlight: backlight {
>> + compatible = "pwm-backlight";
>> + power-supply = <&vcc12v_dcin>;
>> + pwms = <&pwm2 0 25000 0>;
>> + enable-gpios = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&bl_en>;
>> + status = "okay";
>
>This is a friendly reminder during the review process.
>
>It seems my or other reviewer's previous comments were not fully
>addressed. Maybe the feedback got lost between the quotes, maybe you
>just forgot to apply it. Please go back to the previous discussion and
>either implement all requested changes or keep discussing them.
Yes， it seems that the comments were lost， I didn't get any comments about PATCH 5 in my V1.
Anyway, I will check this patch again, and fix the issue I find by myself.
>
>Thank you.
>
>Best regards,
>Krzysztof
>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
