On 11/12/2023 10:49, Andy Yan wrote:
>>> +
>>> + backlight: backlight {
>>> + compatible = "pwm-backlight";
>>> + power-supply = <&vcc12v_dcin>;
>>> + pwms = <&pwm2 0 25000 0>;
>>> + enable-gpios = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&bl_en>;
>>> + status = "okay";
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my or other reviewer's previous comments were not fully
>> addressed. Maybe the feedback got lost between the quotes, maybe you
>> just forgot to apply it. Please go back to the previous discussion and
>> either implement all requested changes or keep discussing them.
>
> Yes， it seems that the comments were lost， I didn't get any comments about PATCH 5 in my V1.
> Anyway, I will check this patch again, and fix the issue I find by myself.
I don't have to repeat the same comment for every same thing to fix.
It's your task to fix all occurrences of the same issue.
Best regards,
Krzysztof
