On 28/11/2023 11:32, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Tue, Nov 28, 2023 at 10:51 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> On 26/11/2023 00:28, Niklas Söderlund wrote: >>> Compatibles can come in two formats. Either "vendor,ip-soc" or >>> "vendor,soc-ip". Add a DT schema file documenting Renesas preferred >>> policy and enforcing it for all new compatibles, except few existing >>> patterns. >>> >>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > >>> + # Legacy namings - variations of existing patterns/compatibles are OK, >>> + # but do not add completely new entries to these: >>> + - pattern: "^renesas,can-[a-z0-9]+$" >>> + - pattern: "^renesas,dmac-[a-z0-9]+$" >>> + - pattern: "^renesas,du-[a-z0-9]+$" >>> + - pattern: "^renesas,ether-[a-z0-9]+$" >>> + - pattern: "^renesas,etheravb-[a-z0-9]+$" >>> + - pattern: "^renesas,etheravb-rcar-gen[0-9]$" >>> + - pattern: "^renesas,gether-[a-z0-9]+$" >>> + - pattern: "^renesas,gpio-[a-z0-9]+$" >>> + - pattern: "^renesas,hscif-[a-z0-9]+$" >>> + - pattern: "^renesas,i2c-[a-z0-9]+$" >>> + - pattern: "^renesas,iic-[a-z0-9]+$" >>> + - pattern: "^renesas,intc-ex-[a-z0-9]+$" >>> + - pattern: "^renesas,intc-irqpin-[a-z0-9]+$" >>> + - pattern: "^renesas,ipmmu-[a-z0-9]+$" >>> + - pattern: "^renesas,irqc-[a-z0-9]+$" >>> + - pattern: "^renesas,jpu-[a-z0-9]+$" >>> + - pattern: "^renesas,mmcif-[a-z0-9]+$" >>> + - pattern: "^renesas,msiof-[a-z0-9]+$" >>> + - pattern: "^renesas,pci-[a-z0-9]+$" >>> + - pattern: "^renesas,pci-rcar-gen[0-9]$" >>> + - pattern: "^renesas,pcie-[a-z0-9]+$" >>> + - pattern: "^renesas,pcie-rcar-gen[0-9]$" >>> + - pattern: "^renesas,pfc-[a-z0-9]+$" >>> + - pattern: "^renesas,pwm-[a-z0-9]+$" >>> + - pattern: "^renesas,qspi-[a-z0-9]+$" >>> + - pattern: "^renesas,rcar_sound-[a-z0-9]+$" >>> + - pattern: "^renesas,riic-[a-z0-9]+$" >>> + - pattern: "^renesas,rspi-[a-z0-9]+$" >>> + - pattern: "^renesas,sata-[a-z0-9]+(-es1)?$" >>> + - pattern: "^renesas,scif-[a-z0-9]+$" >>> + - pattern: "^renesas,scifa-[a-z0-9]+$" >>> + - pattern: "^renesas,scifb-[a-z0-9]+$" >>> + - pattern: "^renesas,sdhi-[a-z0-9]+$" >>> + - pattern: "^renesas,thermal-[a-z0-9]+$" >>> + - pattern: "^renesas,tmu-[a-z0-9]+$" >>> + - pattern: "^renesas,tpu-[a-z0-9]+$" >>> + - pattern: "^renesas,usb-phy-[a-z0-9]+$" >>> + - pattern: "^renesas,usb2-phy-[a-z0-9]+$" >>> + - pattern: "^renesas,usbhs-[a-z0-9]+$" >>> + - pattern: "^renesas,vin-[a-z0-9]+$" >>> + - pattern: "^renesas,xhci-[a-z0-9]+$" >> >> No, wait, you basically listed most of the SoC as exceptions. What SoC >> blocks exactly are you going to cover in such case with your rules? > > As Renesas was an early adopter of DT, there are a lot of compatible > values that do not follow current best practices. > Unfortunately there is not much we can do about that... > Hm, ok, given how many exceptions you have, just please consider whether this schema will be of any use. IOW, how many of new SoC blocks you have which are not covered by the exceptions? Best regards, Krzysztof
